Skip to content

Conversation

@felix-schwarz
Copy link
Contributor

@felix-schwarz felix-schwarz commented Dec 3, 2020

Description

Fix drag and drop and improve support to run the iOS app on M1 Macs:

  • add drag-out support for files that are not locally available yet
  • improve drag-in support for files, picking the best available representation that can be retrieved as data
  • support for drag & drop in the log file browser

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

- improve drag-in support for files, picking the best available representation that can be retrieved as data
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

- drag and drop bugfixes and cleanups
@jesmrec
Copy link
Contributor

jesmrec commented Jan 26, 2021

Some questions regarding this PR:

add drag-out support for files that are not locally available yet

that means, a file that is not locally available (not downloaded) is able to be dragged?. That happened also before AFAIK. I assume that this is in the same account, not posible to drag&drop between accounts without downloading. I'm missing something here

improve drag-in support for files, picking the best available representation that can be retrieved as data

could you clarify? what does "best available representation" mean? (thanks in advance)

support for drag & drop in the log file browser

this one works fine

OTOH, should i expect copying text and dragging into an account to create a new txt file? (i think we commented this somewhen). In case it is, is this dependant from the version? the iPad i'm using in iOS13

@hosy
Copy link
Collaborator

hosy commented Jan 28, 2021

Some questions regarding this PR:

add drag-out support for files that are not locally available yet

that means, a file that is not locally available (not downloaded) is able to be dragged?. That happened also before AFAIK. I assume that this is in the same account, not posible to drag&drop between accounts without downloading. I'm missing something here

Yes, we had this behavior already, because it is not supported to download an item while dragging. Only locally available files can be dragged out.
Dragging inside the app is possible, because we only need the file id for copying between accounts.

improve drag-in support for files, picking the best available representation that can be retrieved as data

could you clarify? what does "best available representation" mean? (thanks in advance)

A file could have multiple representation and I the best format for saving will be chosen.

support for drag & drop in the log file browser

this one works fine

OTOH, should i expect copying text and dragging into an account to create a new txt file? (i think we commented this somewhen). In case it is, is this dependant from the version? the iPad i'm using in iOS13

I think it should be possible to drag text inside, which should be saved as a new txt file.

@felix-schwarz
Copy link
Contributor Author

felix-schwarz commented Feb 1, 2021

add drag-out support for files that are not locally available yet

that means, a file that is not locally available (not downloaded) is able to be dragged?. That happened also before AFAIK. I assume that this is in the same account, not posible to drag&drop between accounts without downloading. I'm missing something here

It means you can drag a file that is not yet downloaded - and when you drop it, the OC app will download the file and deliver it to the target you dropped it on. IIRC we didn't have that before.

improve drag-in support for files, picking the best available representation that can be retrieved as data

could you clarify? what does "best available representation" mean? (thanks in advance)

When an item is dragged in, it can offer more than one representation. Previously, the last in the list was picked, whatever it was. Now the implementation prefers images, then movies, then PDFs, then raw data. IIRC previously we had the issue that on an M1 Mac mini, a file was dragged in - and instead of the file, a placeholder (stored as last type) was imported.

support for drag & drop in the log file browser

this one works fine

OTOH, should i expect copying text and dragging into an account to create a new txt file? (i think we commented this somewhen). In case it is, is this dependant from the version? the iPad i'm using in iOS13

I'd have to look into this to see what data types we are offered for this.

@jesmrec jesmrec added the Approved by QA Approved by QA label Feb 2, 2021
@hosy hosy merged commit bf9dbb1 into milestone/11.5 Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants